Conversation
There was a problem hiding this comment.
Pull request overview
Adds a feasibility/implementation-plan document for an iPhone capture pipeline that would improve measurement consistency for brightness analysis by introducing metadata-gated ingest, automated import, and (eventually) a dedicated iOS capture app.
Changes:
- Added a new documentation page describing current gaps vs. desired workflow and practical constraints.
- Proposed a 3-phase incremental architecture (metadata-aware import → automatic ingest → iOS capture app).
- Added suggested acceptance criteria for validating capture consistency and metadata provenance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The current app analyzes pre-recorded videos and assumes camera settings are stable enough for relative brightness trends. | ||
|
|
||
| ## What the project already does well | ||
| - Computes brightness using CIE L* from each frame and supports background subtraction and noise/morphological filtering. |
There was a problem hiding this comment.
In Markdown, L* will typically render the * as emphasis. To keep the intended notation consistent with README (which uses L\*), consider escaping the asterisk here (e.g., CIE L\*).
| - Computes brightness using CIE L* from each frame and supports background subtraction and noise/morphological filtering. | |
| - Computes brightness using CIE L\* from each frame and supports background subtraction and noise/morphological filtering. |
| - upload directly to shared storage / API endpoint consumed by the desktop pipeline | ||
|
|
||
| ## Suggested acceptance criteria | ||
| - Repeated static-scene captures produce <= X% frame-level brightness variance across runs. |
There was a problem hiding this comment.
The acceptance criterion uses a placeholder (<= X%). To make this actionable/testable, specify a concrete target (or describe how X is chosen, e.g., based on baseline variance + margin) so teams can evaluate pass/fail consistently.
| - Repeated static-scene captures produce <= X% frame-level brightness variance across runs. | |
| - Repeated static-scene captures produce <= 2% frame-level brightness variance across runs (relative to mean brightness). |
| - upload directly to shared storage / API endpoint consumed by the desktop pipeline | ||
|
|
||
| ## Suggested acceptance criteria | ||
| - Repeated static-scene captures produce <= X% frame-level brightness variance across runs. |
There was a problem hiding this comment.
Same Markdown rendering issue as above: brightness variance criterion includes L*/<= X% style text; consider escaping * (e.g., L\*) so it doesn’t italicize in rendered docs.
Motivation
Description
docs/iphone_capture_pipeline_review.mdwith a focused review covering current gaps, practical constraints, a three-phase incremental architecture (metadata-aware import, automatic ingest, iOS capture app), and suggested acceptance criteria.Testing
pytest -q tests/unit/test_analysis_brightness.py, which failed to run due to an environment dependency (PyQt5import error: missinglibGL.so.1), so no automated tests passed in this environment.Codex Task